[Freeciv-Dev] Re: [PATCH] [aiunit.c-1.43] ai_military_findvictim() cleanup (PR#1264)

[Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Feb 22, 2002 at 08:46:08PM +0000, Gregory Berkolaiko wrote:
>  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > On Fri, Feb 22, 2002 at 09:07:11PM +0100, Petr Baudis wrote:
> > >
> [...]
> > > See the TODO near there. I won't remove it now but in the patch unifying
> > > those
> > > computations (we'll reuse Greg's one or I'll remake it, but it'll be my
> > > top-priority after getting this patch in).
> > 
> > But there would still be no guaranty that the other patch gets in the
> > near future.
> 
> Why not?  Because after Spliff you will discover Ispell package and start
> correcting spelling mistakes in the comments? ;)

a low blow... Petr, send me your latest before you're done for the night. 
I'll look it over and apply it tonight or tomorrow morning. We've about 
gotten the goodie out of this particular patch. Now everybody promise 
that we don't stop looking at the AI code after this and everything will 
be OK.

-mike

PS: I would have preferred int pissed = unit_belligerence(punit), but oh
well.

> 
> The patch Petr is talking about would clean up one of the most convoluted and
> dirty computations in AI code.  And these computation are used a lot!
> 
> G.
> 
> __________________________________________________
> Do You Yahoo!?
> Everything you'll ever need on one web page
> from News and Sport to Email and Music Charts
> http://uk.my.yahoo.com