Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2002:
[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR# 		Home

[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Petr Baudis <pasky@xxxxxxxxxxx>, rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: Raahul Kumar <raahul_da_man@xxxxxxxxx>, Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>, Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264) [aiunit.c-1.38]
From: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>
Date: Fri, 22 Feb 2002 18:25:43 +0000 (GMT) 
 --- Petr Baudis <pasky@xxxxxxxxxxx> wrote: 
> Dear diary, on Fri, Feb 22, 2002 at 05:41:38PM CET, I got a letter,
> where Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...

> > > +           * of code (?). --pasky */
> > > +          benefit = (benefit + 40) * punit->hp / unit_type(punit)->hp;
> > 
> > s/40/unit_value(get_role_unit(F_CITIES, 0))/
> 
> *THAT* is it!
> 

well, it is certainly much nicer but I would have preferred a define/macro:
usually the value of a city is much greater than value of a unit that built
the city.  so ultimately there should be a function city_capture_value or
something.

G.

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com
[Prev in Thread] Current Thread [Next in Thread]