[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Feb 22, 2002 at 05:47:52PM +0100, Petr Baudis wrote:
> Dear diary, on Fri, Feb 22, 2002 at 04:36:10PM CET, I got a letter,
> where Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> told me, that...
> >  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > > On Fri, Feb 22, 2002 at 03:46:06PM +0100, Petr Baudis wrote:
> > > > Dear diary, on Fri, Feb 22, 2002 at 03:38:05PM CET, I got a letter,
> > > > where Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...
> > > > > 
> > [...]
> > > > > So it looks to me that a boolean value would be enough. At least this
> > > > > "- 2 * MORT * TRADE_WEIGHTING" thing can be removed.
> > > > 
> > > > Please see my another mail :^).
> > > 
> > > Which one?
> > 
> > Basically we agree that this unhappiness setting in not used at all.
> 
> It is! It is! It is! Inside findvictim() it is! 

How? Where?

> See latest patch and comment about this in it! :)

Which is the latest? The one I commented?

> > However boolean value will not be sufficient.  You need at least three:
> > NOTHING_TO_KILL
> > SOMETHING_GOOD
> > SOMETHING_SO_GOOD_EVEN_A_BODYGUARD_CANT_RESIST_IT
> > 
> > Then all of them would be used, fx in
> > 
> > 1631       ai_military_findvictim(pplayer, punit, &dest_x, &dest_y);  
> > 1632       if (dest_x == punit->x && dest_y == punit->y) {
> > 1633 /* no one to bash here.  Will try to move onward */
> > 
> > this idiotic if (dest....) would be replaced by a better one
> > if (ai_mil_fv(...) == NOTHING_TO_KILL)
> 

> I would like more to still return best and keep those tests... (my old bones
> feel we might want to take advantage from this value later).

No. IMHO we should remove them. If there are added later (_if_ this
happens) it has to be with reason (you have to give then).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "The primary purpose of the DATA statement is to give names to
   constants; instead of referring to pi as 3.141592653589793 at every
   appearance, the variable PI can be given that value with a DATA
   statement and used instead of the longer form of the constant. This
   also simplifies modifying the program, should the value of pi
   change."
    -- FORTRAN manual for Xerox Computers