[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264)

[Petr Baudis <pasky@xxxxxxxxxxx>]

I skipped some questions for which I believe the reply is obvious when reading
my other mails :^).

Dear diary, on Fri, Feb 22, 2002 at 03:55:13PM CET, I got a letter,
where Raahul Kumar <raahul_da_man@xxxxxxxxx> told me, that...
> > This is an exception and I think it's best this way here. It doesn't wrap at
> > least :^).
> 
> Not much to be done. It's just damn hard to read and parse.

I'll remove it probably, as Raimar suggested.

> > +  
> > +  if (punit->unhappiness > 0) {
> > +    /* When we're causing unhappiness, we'll set best even lower, so that 
> > we
> > +     * will take even targets which we would ignore otherwise (in other
> > words -
> > +     * we're going to commit a suicide). */
> 
> Oh, this makes much more sense. Hmmm, is disbanding/changing support to other
> cities not better than suicide? Not that I care about the life of my units.
> They should all be glad to die for the greater glory of me ;).

Disbanding probably not. We're trying it only when we haven't anyone to commit
suicide on ;). Changing would be probably pretty hard to implement and this is
a lot simpler solution, still working reasonably well.

> > +      /* FIXME: The get_total_defense_power(pdef, punit) should probably 
> > use
> > +       * patt rather than pdef. There also ought to be a better metric for
> > +       * determining this. */
> 
> Defence power should use pdef.

Please don't get me back to this :). Feel free to flame with Greg about it
(altough I think Greg is right; why we should use pdef?).

..snip..
> Goddamn yahoo and their truncated messages. It looks good to me. 

What about getting some decent mail account? ;-)

-- 

                                Petr "Pasky" Baudis

* elinks maintainer                * IPv6 guy (XS26 co-coordinator)
* IRCnet operator                  * FreeCiv AI hacker
.
No one can feel as helpless as the owner of a sick goldfish.
.
Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/