[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264)

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Petr Baudis <pasky@xxxxxxxxxxx> wrote: 
> Dear diary, on Fri, Feb 22, 2002 at 02:02:55PM CET, I got a letter,
> where Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> told me, that...
[....]
> > > > why put TODO when you can DO?
> > > > 
> > > > use is_non_allied_city_tile
> > > 
> > > We meant cities of nations which are in peace with us.
> > 
> > how about is_enemy_city_tile then?
> 
> Much better. However, we should still consider at least possibility to move
> to empty cities of nations which are in peace with us - because the empty 
> city can
> have more value than a peace. Implanting some test there now and hiding the
> possible place for test isn't IMHO a good idea.

okay, makes sense.

although i seem to remember that in payciv you can occupy an undefended enemy
city without declaring war...  maybe it's a false memory.

however I would still change it to is_non_allied_city_tile  AND add a TODO.
I know AI are not allying but one can consievably change this without
introducing diplomacy, e.g. in savegames.

G.


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com