[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264)

[Petr Baudis <pasky@xxxxxxxxxxx>]

Dear diary, on Wed, Feb 20, 2002 at 07:02:16PM CET, I got a letter,
where Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx> told me, that...
> > > > I like it.
> > > > I even started to like SET_BEST macro
> > > 
> > > I haven't looked in detail at the patch yet, but I would propose renaming
> > > it to SET_GOAL instead
> > 
> > If we want to be correct, SET_TARGET or something, it's not really our goal.
> > In our goals we're pretty primitive, we just want to kill *something* here 
> > ;).
> > 
> 
> whatever, we're not _just_ setting best however, we're doing something else
> at the same time. SET_TARGET is fine.

Ok. SET_TARGET.

> > But I like SET_BEST most anyway, as its name is very universal and it may be
> > possible that we'll later use this macro somewhere else as well.
> 
> then add a comment above the define like:
> /* sets the best tile to attack and best's magnitude */

I'll do this as well.



Dear diary, on Wed, Feb 20, 2002 at 07:08:14PM CET, I got a letter,
where Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx> told me, that...
> > > So the only real issue is fixing the big inequality.
> > 
> > Which I won't do in this patch unless Mike (which is probably the one who is
> > going to commit this) will explicitly want me to.
> 
> When I skimmed this last night, I really didn't have a clue what this was
> doing despite the long comment. I'd at the least like to be told what all 
> those function calls are getting us...

Better decision what we should attack and what we shouldn't. Certain
improvement, though I'm not sure how noticable it will be.

> (also figure out how to avoid Syela's comments wrapping...)

Huh? Sorry? :)



Improved patch attached.

-- 

                                Petr "Pasky" Baudis

* elinks maintainer                * IPv6 guy (XS26 co-coordinator)
* IRCnet operator                  * FreeCiv AI hacker
.
No one can feel as helpless as the owner of a sick goldfish.
.
Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/

findvictim-cleanup.patch
Description: Text document