[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264)

[Petr Baudis <pasky@xxxxxxxxxxx>]

Dear diary, on Fri, Feb 22, 2002 at 02:02:55PM CET, I got a letter,
where Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> told me, that...
>  --- Petr Baudis <pasky@xxxxxxxxxxx> wrote: 
> > Dear diary, on Thu, Feb 21, 2002 at 06:03:22PM CET, I got a letter,
> > where Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> told me, that...
> > >  --- Petr Baudis <pasky@xxxxxxxxxxx> wrote: 
> > > > Attached improved patch based on Mike's suggestion from next thread
> > (TODO
> > > > comment for diplomacy vs. capturing empty cities).
> > > 
> > > why put TODO when you can DO?
> > > 
> > > use is_non_allied_city_tile
> > 
> > We meant cities of nations which are in peace with us.
> 
> how about is_enemy_city_tile then?

Much better. However, we should still consider at least possibility to move to
empty cities of nations which are in peace with us - because the empty city can
have more value than a peace. Implanting some test there now and hiding the
possible place for test isn't IMHO a good idea.

I'm sure we'll remember this when doing AI diplomacy patch and noticing the
TODO here.

-- 

                                Petr "Pasky" Baudis

* elinks maintainer                * IPv6 guy (XS26 co-coordinator)
* IRCnet operator                  * FreeCiv AI hacker
.
No one can feel as helpless as the owner of a sick goldfish.
.
Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/