[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264)

[Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Feb 20, 2002 at 06:47:28PM +0100, Petr Baudis wrote:
> Dear diary, on Wed, Feb 20, 2002 at 06:04:11PM CET, I got a letter,
> where Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx> told me, that...
> > > 
> > > I like it.
> > > I even started to like SET_BEST macro
> > 
> > I haven't looked in detail at the patch yet, but I would propose renaming
> > it to SET_GOAL instead
> 
> If we want to be correct, SET_TARGET or something, it's not really our goal.
> In our goals we're pretty primitive, we just want to kill *something* here ;).
> 

whatever, we're not _just_ setting best however, we're doing something else
at the same time. SET_TARGET is fine.

> But I like SET_BEST most anyway, as its name is very universal and it may be
> possible that we'll later use this macro somewhere else as well.

then add a comment above the define like:
/* sets the best tile to attack and best's magnitude */

-mike

> 
> -- 
> 
>                               Petr "Pasky" Baudis
> 
> * elinks maintainer                * IPv6 guy (XS26 co-coordinator)
> * IRCnet operator                  * FreeCiv AI hacker
> .
> No one can feel as helpless as the owner of a sick goldfish.
> .
> Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/