[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Feb 22, 2002 at 06:43:10PM +0100, Petr Baudis wrote:
> Dear diary, on Fri, Feb 22, 2002 at 06:14:50PM CET, I got a letter,
> where Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...
> > > > > > > So it looks to me that a boolean value would be enough. At least 
> > > > > > > this
> > > > > > > "- 2 * MORT * TRADE_WEIGHTING" thing can be removed.
> > > > > > 
> > > > > > Please see my another mail :^).
> > > > > 
> > > > > Which one?
> > > > 
> > > > Basically we agree that this unhappiness setting in not used at all.
> > > 
> > > It is! It is! It is! Inside findvictim() it is! 
> > 
> > How? Where?
> 
> | Ok, they aren't. What broke our predictions today was the fact that desire 
> may
> | be negative - thus the mean of the unhappy calculation was completely 
> opposite
> | to the one we thought.
> 
> And from the latest code:
> 
>     /* When we're causing unhappiness, we'll set best even lower, so that we
>      * will take even targets which we would ignore otherwise (in other words 
> -
>      * we're going to commit a suicide). */

I still don't understand.

> However, I agree that the latest patch and this comment was pretty hard to 
> find
> now even to me in this thread ;-). Next patches will be really marked with
> revision number in the subject (and rather at the start of the subject as end

> of it isn't even visible in mutt on 132-chars wide screen at some places of 
> the

/me has only a 128-chars wide screen.

> thread :).
> 
> > > See latest patch and comment about this in it! :)
> > 
> > Which is the latest? The one I commented?
> 

> The one I sent you now :).

You know that "now" is a relative thing ;)

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Premature optimization is the root of all evil."
    -- D. E. Knuth in "Structured Programming with go to Statements"