[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264) [aiunit.c-1.38]

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Feb 22, 2002 at 06:25:43PM +0000, Gregory Berkolaiko wrote:
>  --- Petr Baudis <pasky@xxxxxxxxxxx> wrote: 
> > Dear diary, on Fri, Feb 22, 2002 at 05:41:38PM CET, I got a letter,
> > where Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...
> 
> > > > +           * of code (?). --pasky */
> > > > +          benefit = (benefit + 40) * punit->hp / unit_type(punit)->hp;
> > > 
> > > s/40/unit_value(get_role_unit(F_CITIES, 0))/
> > 
> > *THAT* is it!
> > 

> well, it is certainly much nicer but I would have preferred a define/macro:
> usually the value of a city is much greater than value of a unit that built
> the city.  so ultimately there should be a function city_capture_value or
> something.

Ack.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Reality? That's where the pizza delivery guy comes from!"