[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Feb 22, 2002 at 02:30:26PM -0600, Mike Kaufman wrote:
> On Fri, Feb 22, 2002 at 09:25:49PM +0100, Raimar Falke wrote:
> > > > ) suggests. Is it valid for a ruleset to set uk_happy >1?
> > > 
> > > It looks it's 2 for aggressive units and 1 for other units?
> > 
> > It is 0 for non-aggressive units and it could be the uk_happy value
> > from the ruleset. However uk_happy in the standard rulesets are all 0
> > or 1. So currently it is a boolean.
> 
> let's not hobble ourselves and make it a boolean. Somebody should be able
> to create nasty units that create lots of unhappiness.

Ack. But than
  ./ai/advdomestic.c:603:          if (punit->unhappiness) values[id] += t * 2;
  ./ai/aiunit.c:758:  if (punit->unhappiness) best = 0 - 2 * MORT * 
TRADE_WEIGHTING; /* desperation */
needs to be adjusted.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "That's fundamental game play!  My main enemy is *ALWAYS* fighting 
  a 4-front war.  I make sure of it!"
    -- Tony Stuckey, freeciv-dev