Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2002:
[Freeciv-Dev] Re: [PATCH] [aiunit.c-1.42] ai_military_findvictim() clean 		Home

[Freeciv-Dev] Re: [PATCH] [aiunit.c-1.42] ai_military_findvictim() clean

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: Raahul Kumar <raahul_da_man@xxxxxxxxx>, Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>, Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] [aiunit.c-1.42] ai_military_findvictim() cleanup (PR#1264)
From: Petr Baudis <pasky@xxxxxxxxxxx>
Date: Fri, 22 Feb 2002 20:37:12 +0100 
(note that 1.41 was sync with official CVS)

Dear diary, on Fri, Feb 22, 2002 at 08:00:31PM CET, I got a letter,
where Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...
> On Fri, Feb 22, 2002 at 07:20:43PM +0100, Petr Baudis wrote:
> > > Could be replaced by
> > > > +          benefit = (benefig * punit->hp) / unit_type(punit)->hp;
> > +          benefit *= punit->hp / unit_type(punit)->hp;
> 
> Wrong. It will first do the division (as integer) and than the
> multiplication.

Correct. Thanks :).

Fixed patch attached.

-- 

                                Petr "Pasky" Baudis

* elinks maintainer                * IPv6 guy (XS26 co-coordinator)
* IRCnet operator                  * FreeCiv AI hacker
.
No one can feel as helpless as the owner of a sick goldfish.
.
Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/

Attachment: findvictim-cleanup.patch
Description: Text document

[Prev in Thread] Current Thread [Next in Thread]