[Freeciv-Dev] Re: PATCH: tile markers

[Teemu Kurppa <tkurppa@xxxxxxxxxx>]

Raimar Falke wrote:
> 
> On Sat, Dec 15, 2001 at 11:53:25AM +0200, Teemu Kurppa wrote:
> > A Couple of notes on the implementation:
> > - Tile marker locations are stored in list. For that, I introduced a new
> > type "coords", which is just a coordinate pair (x,y).
> 
> common/map.h contains:
> struct map_position {
>   int x,y;
> };

Ok, I'll change patch to use that. Can I introduce type
map_position_list in map.h amd map.c also ? To me it seems proper place.

> > - Tile markers are not saved anywhere, so they are lost, if you get
> > temporarily disconnected. This a bit inconvenient, but I'm not sure is
> > it the worth of trouble to bring marker information to server.
> 
> Use attributes. (client/attribute)

I'll look on them. But as I wrote in one of the mails, I'll leave
further development of markers to someone with a better vision of their
other usages.

> > - I didn't yet implement the view tile markers -toggle, which probably
> > should be there.
> 
> Yes.
This is now implemented. 

Teemu Kurppa

P.S. Raimar, I have now some time and I can implement the last missing
part (the one you suggested) of unique_city_names patch. So, don't put
your energy on that.