[Freeciv-Dev] Re: (PR#8754) effects patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

Mike Kaufman wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
> 
> On Wed, Jul 07, 2004 at 10:08:30AM -0700, Per Inge Mathisen wrote:
> 
>>On Wed, 7 Jul 2004, Jason Short wrote:
>>
>>>However I'd be in favor of eventually replacing these with a single
>>>EFT_OUTPUT_PER_TILE, with a parameter that tells which output
>>>(food/prod/trade/lux/sci/gold). A similar change would allow the
>>>removal of a number of other effects.
>>
>>Yes, this would be really nice.
> 
> No, not really, it would mean extra checks in the code just to make these
> work, so what's the point really? It certainly doesn't make life simpler.

I think you miss the beauty.  Ideally we would have just one function 
get_tile_output() rather than get_tile_trade, get_tile_food, 
get_tile_shields.

jason