[Freeciv-Dev] Re: (PR#8754) effects patch

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Wed, 7 Jul 2004, Per Inge Mathisen wrote:

> I think we should remove EFT_SIZE_UNLIMIT. Instead we can use EFT_SIZE_ADJ
> with a really big number.

I don't like that kludge very much. What if someone increases the max city
size for some sort of reason? Then the rulesets could cease to work
properly.

> What happened to EFT_SPY_RESISTANT? Is it dead? It is still in the patch.

EFT_SPY_RESISTANT is working just fine. Palace uses it.

> *Please* prune the effects list in effects.h! Unusable and/or deprecated
> effects should not be there.

I was leaving that for last (probably post commit), because it needs to be
discussed effect by effect. It is mostly a matter of how you want the game
rules to work, rather than how the effects infrastructure needs to work.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa