Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2004:
[Freeciv-Dev] Re: (PR#8754) effects patch
Home

[Freeciv-Dev] Re: (PR#8754) effects patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: vasc@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#8754) effects patch
From: "Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 6 Jul 2004 17:42:50 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Tue, Jul 06, 2004 at 03:17:11PM -0700, Jason Short wrote:
> 
> So what do we do next?  This patch is 200k in size.  I don't want to 
> commit it all at once, since surely no review can encompass it all.  Can 
> we agree on the design and then work with smaller patches to get toward 
> that goal?

I'm willing to review the patch when uniqueness issues have gone away.
Though I haven't looked at the patch in a while, I'm not worried (yet)
about the size. Splitting it up just makes the initial development harder.

-mike




[Prev in Thread] Current Thread [Next in Thread]