[Freeciv-Dev] Re: (PR#8754) effects patch

["Per Inge Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Wed, 7 Jul 2004, Per Inge Mathisen wrote:
> *Please* prune the effects list in effects.h! Unusable and/or deprecated
> effects should not be there.

I think we should remove:

EFT_MAKE_CONTENT_MIL_PER
EFT_FOOD_PER_TILE
EFT_TRADE_PER_TILE
EFT_REVOLT_DIST_PCT

in addition to any that are unsupported.

Either README.effects or buildings.ruleset is wrong on Courthouse having
EFT_REVOLT_DIST_PCT. Shouldn't this be EFT_REVOLT_DIST_ADJ?

EFT_NO_UNHAPPY is not really necessary - we can use EFT_FORCE_CONTENT + a
high number instead.

What is EFT_NO_UPKEEP and how is different from EFT_UPKEEP_FREE? It is not
documented.

  - Per