[Freeciv-Dev] Re: (PR#8754) effects patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

Mike Kaufman wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
> 
> On Tue, Jul 06, 2004 at 03:17:11PM -0700, Jason Short wrote:
> 
>>So what do we do next?  This patch is 200k in size.  I don't want to 
>>commit it all at once, since surely no review can encompass it all.  Can 
>>we agree on the design and then work with smaller patches to get toward 
>>that goal?
> 
> I'm willing to review the patch when uniqueness issues have gone away.
> Though I haven't looked at the patch in a while, I'm not worried (yet)
> about the size. Splitting it up just makes the initial development harder.

I don't want to split the patch up into 20 mini-patches.  I want to use 
the patch as a target and make individual patches one at a time.  These 
patches can then get much closer review than the total patch would.

jason