[Freeciv-Dev] (PR#8754) effects patch

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

> [vasc - Wed Jul 07 02:30:29 2004]:
> 
> The sources cache still needs to be generalized. That will have
> minor impact in the code although it will break savedgame compatibility
> and increase the memory footprint.
> 
> The most tiresome thing was to remove the legacy checks for buildings
> and re-check the ruleset. The largest portion of the patch, by far,
> deals with this.
> 
> Some cleanup and tweaks may be nice afterwards, but these should be
> minor and focused.

One final note: the current code should work as is for the default
ruleset effects. It just isn't as extensible as it could be if it had a
generalized sources cache. Effect ranges are mostly hardcoded right
now.