[Freeciv-Dev] Re: (PR#8754) effects patch

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Wed, 7 Jul 2004, Per Inge Mathisen wrote:

> I think we should remove:
>
> EFT_MAKE_CONTENT_MIL_PER
> EFT_FOOD_PER_TILE
> EFT_TRADE_PER_TILE
> EFT_REVOLT_DIST_PCT
>
> in addition to any that are unsupported.

EFT_FOOD_PER_TILE is supported and required for Supermarket.
EFT_TRADE_PER_TILE is supported and required for Super Highways.

EFT_MAKE_CONTENT_MIL_PER is supported, just not used in the default
ruleset. I think this is used by Civ 1's Womens Suffrage.

There are some effects in there which are unused however. Like
EFT_BARB_*, EFT_MAKE_CONTENT_PCT, EFT_IMPROVE_REP (Civ 2 Eiffel Tower).

The question is, do you wish to support them in the future or not,
despite being unsupported in the old pre-effects code?

> Either README.effects or buildings.ruleset is wrong on Courthouse having
> EFT_REVOLT_DIST_PCT. Shouldn't this be EFT_REVOLT_DIST_ADJ?

buildings.ruleset is the authoritative source until README.effects is
updated. I used EFT_REVOLT_DIST_PCT because Courthouse reduces the
distance to capital by 75%. *_ADJ does not make much sense for the
current rulesets.

See city_incite_cost() in server/cityturn.c.

> EFT_NO_UNHAPPY is not really necessary - we can use EFT_FORCE_CONTENT + a
> high number instead.

This is the same thing as for the city size, I don't like it.

> What is EFT_NO_UPKEEP and how is different from EFT_UPKEEP_FREE? It is not
> documented.

It isn't very different. EFT_UPKEEP_FREE makes improvements below a
certain cost free (e.g. Adam Smith) and EFT_NO_UPKEEP simply makes it
free without arguments (e.g. Temple under Fundamentalism in Civ 2).

I could consider merging these, since the building cost is defined in the
rulesets and fixed, but this can only be done after the generalized sources
cache is implemented.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa