[Freeciv-Dev] Re: (PR#8754) effects patch

["Per Inge Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Tue, 6 Jul 2004, Mike Kaufman wrote:
> On Tue, Jul 06, 2004 at 03:17:11PM -0700, Jason Short wrote:
> > So what do we do next? This patch is 200k in size.  I don't want to
> > commit it all at once, since surely no review can encompass it all. Can
> > we agree on the design and then work with smaller patches to get toward
> > that goal?
>
> I'm willing to review the patch when uniqueness issues have gone away.
> Though I haven't looked at the patch in a while, I'm not worried (yet)
> about the size. Splitting it up just makes the initial development harder.

I agree, and I would also like to see it committed as soon as the API is
stable, even if the AI is totally screwed up as a result. I will post an
update of the AI code very soon.

eff patch 12 does not compile with --enable-debug=yes, as there is some
debug-enabled code in client/packhand.c that needs updating.

I think we should remove EFT_SIZE_UNLIMIT. Instead we can use EFT_SIZE_ADJ
with a really big number.

What happened to EFT_SPY_RESISTANT? Is it dead? It is still in the patch.

*Please* prune the effects list in effects.h! Unusable and/or deprecated
effects should not be there.

  - Per