[Freeciv-Dev] Re: (PR#8754) effects patch

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Thu, Jul 08, 2004 at 03:34:29PM -0700, Vasco Alexandre da Silva Costa wrote:
 
> The sources cache is pretty much separate from the effects code. You
> could implement it any way you desire as long as it provides the
> required API functionality.

so the only places in the code now that think that wonders are unique are
in the core effects code?

> I think I will just kludge these for now like Ben did, but this code
> needs to be re-thought. It is indeed very nasty. Do you know that
> ticket's number? It could be interesting.

PR#3603

[snip various palace issues]

yeah, ok, these all suck, but my question is that "Capital_Exists" and
"Capital_City" should take care of most of these issues. What if you have
multiple Capital_Exists improvements? Also some or all of these could be
made additional effects. I don't really like the idea of special-casing a
particular improvement.
 
> It is short for "element". It is like using "i", "it", "iterator" or
> "node" as variable names.

hmm, I don't like. Using "e*" in the effects code gives the impression of a
special naming convention.