Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2004:
[Freeciv-Dev] Re: (PR#8754) effects patch 		Home

[Freeciv-Dev] Re: (PR#8754) effects patch

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: vasc@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#8754) effects patch
From: "Jason Dorje Short" <jdorje@xxxxxxxxxxx>
Date: Tue, 13 Jul 2004 20:32:55 -0700
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

This change:

-    if (pcity->currently_building == B_CAPITAL) {
+    if (pcity->currently_building == B_CAPITAL_CITY) {

is surely a bug.  B_CAPITAL is capitalization but B_CAPITAL_CITY is 
palace.  B_CAPITAL_CITY is a bad name and having a separate global (not 
inside the game struct) is even worse.

jason
[Prev in Thread] Current Thread [Next in Thread]