[Freeciv-Dev] Re: (PR#8754) effects patch

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Tue, 13 Jul 2004, Jason Dorje Short wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
>
> This change:
>
> -    if (pcity->currently_building == B_CAPITAL) {
> +    if (pcity->currently_building == B_CAPITAL_CITY) {
>
> is surely a bug.  B_CAPITAL is capitalization but B_CAPITAL_CITY is
> palace.  B_CAPITAL_CITY is a bad name and having a separate global (not

Duh. That was one of my late night changes. Thanks for spotting the bug.

> inside the game struct) is even worse.

It is not unheard of. There are all sorts of global data not in the game
struct. Like the ruleset buildings, techs, units data, etc.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa