[Freeciv-Dev] (PR#8754) effects patch

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

> [per@xxxxxxxxxxx - Wed Jul 14 08:42:59 2004]:
> 
> > Similarly, what's the difference between
> > can_eventually_build_improvement and can_build_improvement_direction?
> >
> > Obviously these are logically different (except for the "can" versus
> > "could" difference which seems purelysemantic).But why does the user
> > need both?And how is he supposed to tell which is which?
> 
> This is in the code now, and is not a problem created by the effects
> patch. So it is odd of you to chastise Vasco for adding unrelated changes
> to the patch, and then encourage him to add more of the same ;)
> 
> The subtle differences between the functions can probably be explained by
> AI needs.

Basically. And the reason why the can_build_improvement_direct functions
don't check for obsolescence is because this is necessary for
building_upgrades_to.

The can_build_unit_direct works exactly the same way, and I never heard
anyone complain about it. :-)