[Freeciv-Dev] Re: (PR#8754) effects patch

["Jason Dorje Short" <jdorje@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

Vasco Alexandre da Silva Costa wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
> 
>>[jdorje@xxxxxxxxxxx - Wed Jul 14 05:44:44 2004]:
>>
>>There are a large number of unnecessary changes.  Why do you remove 
>>wants_to_be_bigger?  Why do you change the parameters of so many 
> 
> Because it wasn't used anywhere and was completely hardcoded. Why should
> I bother to convert it, when killing it is so much simpler?

Oh duh.

>>functions (that are not otherwise modified) to be const?
> 
> Because someone changed lots of functions in common/city.c to const and
> I had to do the same.

Or you get compile errors?  That's obnoxious.

But what about the code in map.[ch]?  The only changes you make here are 
to make a function have const parameters.

jason