[Freeciv-Dev] (PR#8754) effects patch
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: |
undisclosed-recipients: ; |
Subject: |
[Freeciv-Dev] (PR#8754) effects patch |
From: |
"Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx> |
Date: |
Wed, 14 Jul 2004 06:37:46 -0700 |
Reply-to: |
rt@xxxxxxxxxxx |
<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
> [jdorje@xxxxxxxxxxx - Wed Jul 14 05:44:44 2004]:
>
> There are a large number of unnecessary changes. Why do you remove
> wants_to_be_bigger? Why do you change the parameters of so many
Because it wasn't used anywhere and was completely hardcoded. Why should
I bother to convert it, when killing it is so much simpler?
> functions (that are not otherwise modified) to be const?
Because someone changed lots of functions in common/city.c to const and
I had to do the same.
> It makes it harder to find the real changes.
- [Freeciv-Dev] Re: (PR#8754) effects patch, (continued)
- [Freeciv-Dev] Re: (PR#8754) effects patch, Per Inge Mathisen, 2004/07/14
- [Freeciv-Dev] Re: (PR#8754) effects patch, Per Inge Mathisen, 2004/07/14
- [Freeciv-Dev] Re: (PR#8754) effects patch, Vasco Alexandre da Silva Costa, 2004/07/14
- [Freeciv-Dev] (PR#8754) effects patch, Vasco Alexandre da Silva Costa, 2004/07/14
- [Freeciv-Dev] (PR#8754) effects patch, Vasco Alexandre da Silva Costa, 2004/07/14
- [Freeciv-Dev] (PR#8754) effects patch, Vasco Alexandre da Silva Costa, 2004/07/14
- [Freeciv-Dev] (PR#8754) effects patch, Vasco Alexandre da Silva Costa, 2004/07/14
- [Freeciv-Dev] (PR#8754) effects patch, Vasco Alexandre da Silva Costa, 2004/07/14
- [Freeciv-Dev] (PR#8754) effects patch, Vasco Alexandre da Silva Costa, 2004/07/14
- [Freeciv-Dev] (PR#8754) effects patch, Vasco Alexandre da Silva Costa, 2004/07/14
- [Freeciv-Dev] (PR#8754) effects patch,
Vasco Alexandre da Silva Costa <=
- [Freeciv-Dev] (PR#8754) effects patch, Vasco Alexandre da Silva Costa, 2004/07/14
- [Freeciv-Dev] Re: (PR#8754) effects patch, Jason Dorje Short, 2004/07/14
- [Freeciv-Dev] Re: (PR#8754) effects patch, Jason Dorje Short, 2004/07/14
[Freeciv-Dev] Re: (PR#8754) effects patch, Jason Dorje Short, 2004/07/14
- [Freeciv-Dev] Re: (PR#8754) effects patch, Jason Dorje Short, 2004/07/14
- [Freeciv-Dev] Re: (PR#8754) effects patch, Jason Dorje Short, 2004/07/14
- [Freeciv-Dev] Re: (PR#8754) effects patch, Per Inge Mathisen, 2004/07/14
- [Freeciv-Dev] (PR#8754) effects patch, Vasco Alexandre da Silva Costa, 2004/07/15
- [Freeciv-Dev] Re: (PR#8754) effects patch, Jason Dorje Short, 2004/07/15
- [Freeciv-Dev] Re: (PR#8754) effects patch, Jason Dorje Short, 2004/07/15
|
|