[Freeciv-Dev] Re: [Patch] New city dialog (8)

[Daniel Sjölie <deepone@xxxxxxxxxx>]

On 2001-09-03 14:41:08, Mike Kaufman wrote:
> 
> with Daniel's 'blessing', I've put a version 8 of the city dialog patch in
> incoming/ on the ftp site.
> 
> things that have changed:
> 
> o implemented granary and pollution label coloring
> o fixed spy problem
> o put a frame around the dialog that has city name and size (like old
>   dialog)
> o extensive internal work (mainly changes from the old v.12.1 that
>   apparently got lost somewhere)
> o made it a gtk_dialog instead of a gtk_window. (this changes the spacing
>   around the bottom buttons, it can be reverted if there's an outcry)

I have no problem with this...

> things todo: (at least on my todo list)
> 
> o fix happiness so the citizen pixmaps get condensed.
> o move enable tooltips to the misc. page.

I still don't like that but if everyone else thinks this is a good
idea I'll accept that...

However, my thought with these tooltips were not that You would keep
them enabled but rather that You'd enable them just to read them once
when You needed to... I think they're a bit verbose to have on all the
time, they certainly should default to off and the newbie who really
needs them might not find them as easliy on the Misc page...

> o maybe move the notebook page creation back to function calls
> 
> things I may not have the knowledge to do: (but I'll look)
> 
> o fix the transparency issue that Daniel Speyer noted.
> o fix the sensitivity shift in the map that Christian noted.
> 
> Daniel: It's possible that I accidentally backed out of some changes that
> you did. Please check and make sure.

All the features seems to be there...
And I do agree Your changes to my code are improvements... :)

> Also: you have
> gtk_widget_set_name() scattered around. What does that do, and is it
> necessary?

I did take that from the old dialog but I believe it connects to:
style "city_label"
{
      font = "-b&h-lucidatypewriter-bold-r-normal-*-10-*-*-*-*-*-*-*"
}
in .../share/freeciv/freeciv.rc

By the way, do You know why GtkStyle didn't work?
(It worked in the old dialog)

And, by the way again, did You get any errors about
gtk_table_set_col_spacing now? Cause I can't see the difference from
earlier when others got it and I didn't... I guess it's possible I made
something stupid with the patch others had that problem with but I
tested it on cvs myself...

> Are there any other issues anyone is aware of? Does anyone still have
> any basic design issues? You have about 3 hours before I'm out of contact
> for the day.

Christian allready mentioned some and there was the issue about more
space between frames... Other that and those You mentioned above I
can't think of any... Oh... Performace perhaps?

/Daniel

-- 
Now take a deep breath, smile and don't take life so seriously... :)