[Freeciv-Dev] [Patch] New city dialog (8)

[Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>]

with Daniel's 'blessing', I've put a version 8 of the city dialog patch in
incoming/ on the ftp site.

things that have changed:

o implemented granary and pollution label coloring
o fixed spy problem
o put a frame around the dialog that has city name and size (like old
  dialog)
o extensive internal work (mainly changes from the old v.12.1 that
  apparently got lost somewhere)
o made it a gtk_dialog instead of a gtk_window. (this changes the spacing
  around the bottom buttons, it can be reverted if there's an outcry)

things todo: (at least on my todo list)

o fix happiness so the citizen pixmaps get condensed.
o move enable tooltips to the misc. page.
o maybe move the notebook page creation back to function calls

things I may not have the knowledge to do: (but I'll look)

o fix the transparency issue that Daniel Speyer noted.
o fix the sensitivity shift in the map that Christian noted.

Daniel: It's possible that I accidentally backed out of some changes that
you did. Please check and make sure. Also: you have
gtk_widget_set_name() scattered around. What does that do, and is it
necessary?

Are there any other issues anyone is aware of? Does anyone still have
any basic design issues? You have about 3 hours before I'm out of contact
for the day.

-mike