[Freeciv-Dev] Re: [Patch] New city dialog (8)

[Christian Knoke <ChrisK@xxxxxxxx>]

Am Montag,  3. September 2001 21:41 schrieb Mike Kaufman:
> with Daniel's 'blessing', I've put a version 8 of the city dialog
> patch in incoming/ on the ftp site.

:-)

>
> things that have changed:
>
> o implemented granary and pollution label coloring
> o fixed spy problem
> o put a frame around the dialog that has city name and size (like old
>   dialog)

Good. I suggest removing the city size from the title bar then.

> o extensive internal work (mainly changes from the old v.12.1 that
>   apparently got lost somewhere)
> o made it a gtk_dialog instead of a gtk_window. (this changes the
> spacing around the bottom buttons, it can be reverted if there's an
> outcry)

Looks good.

>
> things todo: (at least on my todo list)
>
> o fix happiness so the citizen pixmaps get condensed.
> o move enable tooltips to the misc. page.

I suggest to move "Undo" up (right beside "Down") and then
deleting the entire row.

> o maybe move the notebook page creation back to function calls
>
> things I may not have the knowledge to do: (but I'll look)
>
> o fix the transparency issue that Daniel Speyer noted.
> o fix the sensitivity shift in the map that Christian noted.
>
> Daniel: It's possible that I accidentally backed out of some changes
> that you did. Please check and make sure. Also: you have
> gtk_widget_set_name() scattered around. What does that do, and is it
> necessary?
>
> Are there any other issues anyone is aware of? Does anyone still have
> any basic design issues? You have about 3 hours before I'm out of
> contact for the day.

A must have are shortcuts for the buttons.

And then something I have already written:

--------
Keys: "Ins" and "Del" for switching the panes is not very
intiutive. Could you change this to shift-cursor or ctrl-cursor?
"Ins" and "del" then could be used for inserting / deleting items
in the worklist. You'd have full keyboard control then.

On the overview page, you can't see whether you have a worklist.
So, if you change production, you will erase any worklist accidentally.
A worklist indicator would be nice. I'm thinking of a small thing,
maybe "WL" behind the "Currently building: .." line.
--------

.. or simply: "Currently building: Legion (and more)"

At last a suggestion for a redesign:

Exchange "supported units" and "established trade routes". 
Reason: That is the way it is now. It is easier to compare
both rows of units, looking for supported and not present e.g.
It is the same order as on the units page. It is irritating
now, when you switch to the units page.

As a consequence of this move, remove the last line of the Trade routes
"No trade routes exist". Instead, write a line "Trade routes: +7"
(e.g.) into the topleft display. And, shouldn't there be a line "Corruption"
in that display?

>
> -mike

I can't think of anything else. I'm looking forward to have a
really improved city dialog then.

Christian

-- 
* Christian Knoke                           +49 4852 92248 *
* D-25541 Brunsbuettel                  Wurtleutetweute 49 *
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.