[Freeciv-Dev] Re: [Patch] New city dialog (6)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Sep 01, 2001 at 04:01:43PM -0500, Mike Kaufman wrote:
> 
> 
> > 
> > First, a patch from Mike for the Sentry units button is included...
> > Behavior: sentries all idle units. Fortified units and settlers doing
> > activity on the city tile are not affected.
> > I also added automated units to the list of units not sentried...
> 
> good.
> > 
> > Also fixed the city report bug the right way this time... :)
> > 
> > In the worklist:
> > Added Up and Down buttons and other minor interface changes...
> > Also changed the way worklists work when You press Next/Prev city...
> > I figure it must have been meant to be a feature that the worklist
> > You had worked on stayed when You switched city but it didn't work well
> > att all... Messed things up when I used it anyway - so I changed it so
> > that changes are applied to the worklist You're leaving when You switch
> > and You get the current worklist for the next city instead... Seems a
> > lot more intuitive to me...
> 
> I agree with Christian's comment. The enable tooltips should be in misc.
> In this context, I agree it should also be "Undo" and waste the
> "Apply" button. Once again, though, we're doing this "3 rows o' buttons" 
> thing again.
> 
> Maybe I should explain: I think that the tabs to the notebook should be on
> the top, because that's where most people expect them, and it
> doesn't crowd the bottom of the dialog. What do people think?

Since freeciv is already exotic in this respect (which system has a
close button at sw?) it is ok to have the notepad at the bottom.

> > I think that's all...
> > 
> > In the city overview:
> > Made the trade routes listing constant size...
> > Reworked the City info listing to use a table and one label per value
> > (eg "13 (+2)") - spent quite some time trying to get changing styles in
> > these to work... I'd like to make the values red when they're "bad"...
> > Didn't manage this though, seems gtk doesn't work quite like I think it
> > should... :} (Ie, I think I know how it should be done but it doesn't
> > work :p) So, if anyone feels like tackling that (Mike?) I certainly
> > wouldn't mind... :)
> 
> I could take a quick look in case I'm outvoted, but as I explained in the
> last post, I don't really like the idea.

You can make it an option.

> > Also added a tooltip to the Granary value explaining the number in
> > paranthesis...
> 
> good.
> 
> > Ahh, right...
> > I changed the Turns value in the available list (in the worklist) to not
> > include the shield stock in the calculation...
> > 
> > That should be it, pretty much...
> > I'm thinking of adding the City info to the Happiness page... Looks like
> > it would fit ok under the map... This should be easy enough now with the
> > rework of the info listing - what do You think?
> 
> yes, do it. That's the other place in the dialog that kinda needs that
> info, since, you might be switching dudes around.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Of course, someone who knows more about this will correct me if I'm
  wrong, and someone who knows less will correct me if I'm right."
    -- David Palmer (palmer@xxxxxxxxxxxxxxxxxx)