[Freeciv-Dev] Re: [Patch] New city dialog (6)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Sep 01, 2001 at 09:25:18PM +0200, Daniel Sjölie wrote:
> On 2001-09-01 19:52:09, Christian Knoke wrote:
> > Am Samstag,  1. September 2001 17:49 schrieb Raimar Falke:
> > > On Sat, Sep 01, 2001 at 11:34:40AM +0200, Daniel Sjölie wrote:
> > > > Ok, here's a new batch...
> > > >
> > >
> > >  - city names in prev/next button
> > 
> > I don't believe it's usefull, it's rather a bit too much good.
> > Varying texts in buttons ?? Cities are in no special order now.
> > Better you change that. Also, a long name would cause resizing
> > the dialog.
> 
> I agree with Christian...

Ok. It looks like I have to code it for myself to see if it feels
right. It may it maybe not.

> > >  - help button for the current queued items
> > 
> > Is this neccessary? You've already choosen that item.
> 
> I agree with Christian... :)

Ok.

> > >  - a bit more space (see gtk_container_set_border_width and second
> > >  argument for gtk_[vh]box_new)
> > 
> > yes.
> 
> Yes, guess I've been reluctant to do this because it was too big from
> the start but I agree it's a bit cramped in places now...
> 
> > >  - colored surpluses
> > 
> > would be nice.
> 
> Indeed it would...
> 
> > >  - since the title bar of the window is a bit unusual can you put the
> > >  name and size right to the citizen pixmap?
> > 
> > I can't see anything unusual with the window title.
> 
> Well, the fact that there is "real info" in it is unusual...

Exactly.

> I'll try writing it right of the pixmap...

Thanks.

> > >  - a comment what these methods which have a "Unclear RF" in its
> > >  header do. I haven't understood:
> > >
> > >   if (w == pdialog->unit.support_unit_button[0]) {
> > >     pdialog->unit.support_unit_pos--;
> > >   } else {
> > >     pdialog->unit.support_unit_pos++;
> > >   }
> > >
> > > this.
> 
> If the button pressed was the first {
>     go to previous "page" with support units
> else
>     go to next "page" with support units

Ahhh. I though it was the actual position of a unit and not a whole
subset/part/block.

> I that more unclear than anything else in there? :)
> 
> I don't know what Unclear RF is... I'll give figuring it out a try...

You can remove this now. And maybe if you have time you can do a
s/[0]/[BUTTON_PREV]/ and s/[1]/[BUTTON_NEXT]/.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "There are three ways to get something done. Do it yourself, hire someone
  to do it for you or forbid your kids to do it."