[Freeciv-Dev] Re: [Patch] New city dialog (6)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Sep 01, 2001 at 11:34:40AM +0200, Daniel Sjölie wrote:
> 
> Ok, here's a new batch...
> 
> Screenshots:
> http://www.acc.umu.se/~deepone/freeciv/overview.png
> http://www.acc.umu.se/~deepone/freeciv/worklist.png
> 
> Patch:
> http://www.acc.umu.se/~deepone/freeciv/new_city_dialog6.diff.gz
> 
> So... Let's see if I can remember what I have done... :)
> 
> First, a patch from Mike for the Sentry units button is included...
> Behavior: sentries all idle units. Fortified units and settlers doing
> activity on the city tile are not affected.
> I also added automated units to the list of units not sentried...
> 
> Also fixed the city report bug the right way this time... :)
> 
> In the worklist:
> Added Up and Down buttons and other minor interface changes...
> Also changed the way worklists work when You press Next/Prev city...
> I figure it must have been meant to be a feature that the worklist
> You had worked on stayed when You switched city but it didn't work well
> att all... Messed things up when I used it anyway - so I changed it so
> that changes are applied to the worklist You're leaving when You switch
> and You get the current worklist for the next city instead... Seems a
> lot more intuitive to me...
> 
> I think that's all...
> 
> In the city overview:
> Made the trade routes listing constant size...
> Reworked the City info listing to use a table and one label per value
> (eg "13 (+2)") - spent quite some time trying to get changing styles in
> these to work... I'd like to make the values red when they're "bad"...
> Didn't manage this though, seems gtk doesn't work quite like I think it
> should... :} (Ie, I think I know how it should be done but it doesn't
> work :p) So, if anyone feels like tackling that (Mike?) I certainly
> wouldn't mind... :)
> Also added a tooltip to the Granary value explaining the number in
> paranthesis...
> 
> Ahh, right...
> I changed the Turns value in the available list (in the worklist) to not
> include the shield stock in the calculation...
> 
> That should be it, pretty much...
> I'm thinking of adding the City info to the Happiness page... Looks like
> it would fit ok under the map... This should be easy enough now with the
> rework of the info listing - what do You think?

 - city names in prev/next button
 - help button for the current queued items
 - a bit more space (see gtk_container_set_border_width and second
 argument for gtk_[vh]box_new)
 - colored surpluses
 - since the title bar of the window is a bit unusual can you put the
 name and size right to the citizen pixmap?
 - a comment what these methods which have a "Unclear RF" in its
 header do. I haven't understood:

  if (w == pdialog->unit.support_unit_button[0]) {
    pdialog->unit.support_unit_pos--;
  } else {
    pdialog->unit.support_unit_pos++;
  }

this.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Life is too short for reboots."