[Freeciv-Dev] Re: [Patch] New city dialog (6)

[Christian Knoke <ChrisK@xxxxxxxx>]

Am Samstag,  1. September 2001 17:49 schrieb Raimar Falke:
> On Sat, Sep 01, 2001 at 11:34:40AM +0200, Daniel Sjölie wrote:
> > Ok, here's a new batch...
> >
>
>  - city names in prev/next button

I don't believe it's usefull, it's rather a bit too much good.
Varying texts in buttons ?? Cities are in no special order now.
Better you change that. Also, a long name would cause resizing
the dialog.

>  - help button for the current queued items

Is this neccessary? You've already choosen that item.

>  - a bit more space (see gtk_container_set_border_width and second
>  argument for gtk_[vh]box_new)

yes.

>  - colored surpluses

would be nice.

>  - since the title bar of the window is a bit unusual can you put the
>  name and size right to the citizen pixmap?

I can't see anything unusual with the window title.

>  - a comment what these methods which have a "Unclear RF" in its
>  header do. I haven't understood:
>
>   if (w == pdialog->unit.support_unit_button[0]) {
>     pdialog->unit.support_unit_pos--;
>   } else {
>     pdialog->unit.support_unit_pos++;
>   }
>
> this.
>
>       Raimar

Christian

-- 
* Christian Knoke                           +49 4852 92248 *
* D-25541 Brunsbuettel                  Wurtleutetweute 49 *
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.