Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2001:
[Freeciv-Dev] Re: [Patch] New city dialog (8)
Home

[Freeciv-Dev] Re: [Patch] New city dialog (8)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Daniel L Speyer <dspeyer@xxxxxxxxxxx>
Cc: Daniel Sjölie <deepone@xxxxxxxxxx>, Christian Knoke <ChrisK@xxxxxxxx>, Freeciv Developers <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [Patch] New city dialog (8)
From: Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxx>
Date: Wed, 5 Sep 2001 00:10:28 +0100 (WET DST)

On Tue, 4 Sep 2001, Daniel L Speyer wrote:

> In testing the new city dialog, I found myself constantly hitting <enter>
> to close it (which doesn't work).  This line should make it do so
>   gtk_widget_grab_default(pdialog->close_command);
> (generating a patch for one line seems excessive).

Please don't use widget grabs on new code. I've been meaning to remove all
widget grabs in the code for a long time. Use an accelerator bound to the
enter key, you should be able to find examples of this in many dialogs in 
the gtk+ client.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa



[Prev in Thread] Current Thread [Next in Thread]