[Freeciv-Dev] Re: New alliances v2 (PR#8394)

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8394 >

On 2004-04-15 13:35:06, Per I. Mathisen wrote:
Very good stuff!
1)
+      } else if (pplayer->team == TEAM_NONE) {
+        char teamname[MAX_LEN_NAME];
+
+        snprintf(teamname, sizeof(teamname), _("Pax %s"),
+                 get_nation_name(pplayer->nation));
+        team_consistency_check;
+        handle_team_add_player(pplayer, pplayer->player_no, teamname);
+      }

What would happen if there was already a team with that name?

2)
+  if (!is_sane_name(name) || strlen(name) > 20) {
+    notify_player_ex(pplayer, -1, -1, E_TREATY_BROKEN,
+                     _("Game: That is a stupid name for an  
alliance."));
+    return;
+  }
We should also search for a '*' in the name.

--
mateusz