[Freeciv-Dev] Re: New alliances v2 (PR#8394)

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8394 >

On Fri, 16 Apr 2004, Mateusz Stefek wrote:
> Very good stuff!

Thanks for reviewing.

> +    } else if (pplayer->team == TEAM_NONE) {
> +      char teamname[MAX_LEN_NAME];
> +
> +      snprintf(teamname, sizeof(teamname), _("Pax %s"),
> +               get_nation_name(pplayer->nation));
> +      team_consistency_check;
> +      handle_team_add_player(pplayer, pplayer->player_no, teamname);
> +    }
>
> What would happen if there was already a team with that name?

The AI would fail to create an alliance. So a human player could create an
alliance with the name Pax+<ai nation> to stop that AI player from
creating an alliance... Fixed.

> +if (!is_sane_name(name) || strlen(name) > 20) {
> +  notify_player_ex(pplayer, -1, -1, E_TREATY_BROKEN,
> +                   _("Game: That is a stupid name for an
> alliance."));
> +  return;
> +}
> We should also search for a '*'in the name.

Good idea.

  - Per