[Freeciv-Dev] Re: (PR#8522) historian agent copies units badly

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8522 >

On Thu, Apr 15, 2004 at 03:00:37PM -0700, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8522 >
> 
> The historian "agent" copies units by doing:
> 
>    *pold_unit = *punit;
> 
> but this isn't safe since some of the fields of the unit are pointers to 
> allocated memory.  If punit is deallocated this will give memory 
> corruption when pold_unit is accessed.
> 
> The only alternative is a copy_unit function:

I agree but we should name this unit_clone.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Python is executable pseudocode. Perl is executable line noise"
    -- Bruce Eckel