[Freeciv-Dev] Re: [RFC] Behaviour of units in eXplore mode near cities

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Feb 18, 2002 at 12:33:22PM +0000, Gregory Berkolaiko wrote:
>  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > On Sun, Feb 17, 2002 at 09:29:23PM +0000, Gregory Berkolaiko wrote:
> > >
> > > yep, you are right.
> > > than nobody should go to cities while exploring (explorers shouldn't
> > attack,
> > > right?)
> > 
> > We could expand the test to
> >   if (map_get_city(x1, y1) && (unit_flag(punit, F_DIPLOMAT) ||
> >                                unit_flag(punit, F_CARAVAN)) ||
> >                                is_military_unit(punit))
> 
> which leaves us whom?  

> explorers?  can they go into cities?  no.

What have I forgot here? Why can't explorers be moved into cities?

> btw, what is the reason for "notify" in
> 320         if (!can_unit_move_to_tile_with_notify(punit, x1, y1, 0))
> 321           continue;
> ??
> I don't think it should be there: player should not be notified if we cannot
> move into tile which is only _considered_.

Congratulation!!! During the cleanup of the move checks
(can_step_taken_wrt_to_zoc and co) I changed the name of the function
from can_unit_move_to_tile to can_unit_move_to_tile_with_notify since
I needed the name can_unit_move_to_tile for some other function. This
change made it clear that something was wrong with the usage of
can_unit_move_to_tile_with_notify. I have never found the time to fix
this. 

You are the first to notice this. This is another strong indication
for me to fix the things if you notice them (even if there aren't part
of the original authors intentions).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The very concept of PNP is a lovely dream that simply does not translate to
  reality. The confusion of manually doing stuff is nothing compared to the
  confusion of computers trying to do stuff and getting it wrong, which they
  gleefully do with great enthusiasm." 
    -- Jinx Tigr in the SDM