[Freeciv-Dev] Re: [RFC] Behaviour of units in eXplore mode near cities

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> On Sun, Feb 17, 2002 at 09:29:23PM +0000, Gregory Berkolaiko wrote:
> >
> > yep, you are right.
> > than nobody should go to cities while exploring (explorers shouldn't
> attack,
> > right?)
> 
> We could expand the test to
>   if (map_get_city(x1, y1) && (unit_flag(punit, F_DIPLOMAT) ||
>                                unit_flag(punit, F_CARAVAN)) ||
>                                is_military_unit(punit))

which leaves us whom?  explorers?  can they go into cities?  no.

btw, what is the reason for "notify" in
320         if (!can_unit_move_to_tile_with_notify(punit, x1, y1, 0))
321           continue;
??
I don't think it should be there: player should not be notified if we cannot
move into tile which is only _considered_.

G.


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com