[Freeciv-Dev] Re: [RFC] Behaviour of units in eXplore mode near cities

[Petr Baudis <pasky@xxxxxxxxxxx>]

Dear diary, on Wed, Feb 20, 2002 at 07:48:37PM CET, I got a letter,
where Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx> told me, that...
> On Wed, Feb 20, 2002 at 07:42:12PM +0100, Petr Baudis wrote:
> > Dear diary, on Mon, Feb 18, 2002 at 03:13:48PM CET, I got a letter,
> > where Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...
> > > On Mon, Feb 18, 2002 at 12:33:22PM +0000, Gregory Berkolaiko wrote:
> > > >  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > > > > On Sun, Feb 17, 2002 at 09:29:23PM +0000, Gregory Berkolaiko wrote:
> > > > > >
> > > > > > yep, you are right.
> > > > > > than nobody should go to cities while exploring (explorers shouldn't
> > > > > attack,
> > > > > > right?)
> > > > > 
> > > > > We could expand the test to
> > > > >   if (map_get_city(x1, y1) && (unit_flag(punit, F_DIPLOMAT) ||
> > > > >                                unit_flag(punit, F_CARAVAN)) ||
> > > > >                                is_military_unit(punit))
> > > > 
> > > > which leaves us whom?  
> > > 
> > > > explorers?  can they go into cities?  no.
> > > 
> > > What have I forgot here? Why can't explorers be moved into cities?
> > 
> > I hope we're talking about foreign cities. As I said, we should generally 
> > test
> > if the city is foreign, no problem in moving through own cities.
> 
> this reminds me that at the bottom of your patch, you should at least write
> a comment to the effect of "when ai diplomacy happens, this should change
> so a unit doesn't always move into (attempt to conquer) an ally's city when 
> it could be doing something better."
> 
> since diplomacy is non-functional anyway, you could write that code here
> just have the new function return 1 (or zero) if that's what you need for
> it to do nothing. 

Good idea! Done, I'll post the new patch to the appropriate thread.

I don't feel like adding new function to do this as probably noone has now
clear idea how the diplomacy stuff will even look like.

-- 

                                Petr "Pasky" Baudis

* elinks maintainer                * IPv6 guy (XS26 co-coordinator)
* IRCnet operator                  * FreeCiv AI hacker
.
No one can feel as helpless as the owner of a sick goldfish.
.
Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/