[Freeciv-Dev] Re: [RFC] Behaviour of units in eXplore mode near cities

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Feb 18, 2002 at 03:13:48PM +0100, Raimar Falke wrote:
> > btw, what is the reason for "notify" in
> > 320         if (!can_unit_move_to_tile_with_notify(punit, x1, y1, 0))
> > 321           continue;
> > ??
> > I don't think it should be there: player should not be notified if we cannot
> > move into tile which is only _considered_.
> 
> Congratulation!!! During the cleanup of the move checks
> (can_step_taken_wrt_to_zoc and co) I changed the name of the function
> from can_unit_move_to_tile to can_unit_move_to_tile_with_notify since
> I needed the name can_unit_move_to_tile for some other function. This
> change made it clear that something was wrong with the usage of
> can_unit_move_to_tile_with_notify. I have never found the time to fix
> this. 
> 
> You are the first to notice this. This is another strong indication
> for me to fix the things if you notice them (even if there aren't part
> of the original authors intentions).

And here is the patch.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "On the eigth day, God started debugging"

can_unit_move_to_tile_with_notify1.diff
Description: Text document