Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2004:
[Freeciv-Dev] Re: (PR#7405) list cleanup 		Home

[Freeciv-Dev] Re: (PR#7405) list cleanup

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#7405) list cleanup
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Tue, 10 Feb 2004 00:16:08 -0800
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=7405 >

On Mon, 9 Feb 2004, Raimar Falke wrote:
> > +assert(conn_list_size(&pplayer->connections) == 0);
> > +conn_list_unlink_all(&pplayer->connections);
>
> If the first doesn't kill the program isn't the second a nop?!

Not if #ifdef NDEBUG...

Also, if an unlink_all() becomes necessary to actually remove all list
data, as my genlist patch does, calling unlink_all() on an empty list is
not superfluous but necessary.

  - Per
[Prev in Thread] Current Thread [Next in Thread]