[Freeciv-Dev] Re: (PR#7405) list cleanup

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7405 >

Raimar Falke wrote:

>>Also, if an unlink_all() becomes necessary to actually remove all list
>>data, as my genlist patch does, calling unlink_all() on an empty list is
>>not superfluous but necessary.
> 
> Uhh. Bad idea. It changes the semantics of the function thus code like:
> 
>   unlink_all()
>   insert()
> 
> becomes broken. Another point is that the function name is plain
> misleading in such a case.

At a minimum this function must be renamed.  Probably the current 
functionality should be retained and a new function (deinit()?) added.

jason