[Freeciv-Dev] Re: (PR#7405) list cleanup

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7405 >

On Tue, Feb 10, 2004 at 01:02:37PM -0800, Per I. Mathisen wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7405 >
> 
> On Tue, 10 Feb 2004, Raimar Falke wrote:
> > > Also, if an unlink_all() becomes necessary to actually remove all list
> > > data, as my genlist patch does, calling unlink_all() on an empty list is
> > > not superfluous but necessary.
> >
> > Uhh. Bad idea. It changes the semantics of the function thus code like:
> >
> > unlink_all()
> > insert()
> >
> > becomes broken.
> 
> That is never used anywhere, AFAICT.

Well you can prove this? Or catch it? Looks like we exchange one
potential problem (code is currently in a working state) with another
one.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I haven't lost my mind - it's backed up on tape somewhere."