[Freeciv-Dev] Re: (PR#7405) list cleanup

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7405 >

On Tue, 10 Feb 2004, Raimar Falke wrote:
> > Also, if an unlink_all() becomes necessary to actually remove all list
> > data, as my genlist patch does, calling unlink_all() on an empty list is
> > not superfluous but necessary.
>
> Uhh. Bad idea. It changes the semantics of the function thus code like:
>
> unlink_all()
> insert()
>
> becomes broken.

That is never used anywhere, AFAICT.

> Another point is that the function name is plain misleading in such a
> case.

That can easily be fixed.

  - Per