[Freeciv-Dev] Re: (PR#7405) list cleanup

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7405 >

On Wed, Feb 11, 2004 at 08:15:29AM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7405 >
> 
> Raimar Falke wrote:
> 
> >>Also, if an unlink_all() becomes necessary to actually remove all list
> >>data, as my genlist patch does, calling unlink_all() on an empty list is
> >>not superfluous but necessary.
> > 
> > Uhh. Bad idea. It changes the semantics of the function thus code like:
> > 
> >   unlink_all()
> >   insert()
> > 
> > becomes broken. Another point is that the function name is plain
> > misleading in such a case.
> 
> At a minimum this function must be renamed. 

> Probably the current 
> functionality should be retained and a new function added.

I agree.

> (deinit()?)

*_free or *_destroy.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Are you saying that you actually used the Classpath Java AWT classes in 
  addition to the GTK peers and got them to display something?
  Wow.  That's way better than I did and I wrote the code!"
    -- Aaron M. Renn in the classpath mailing list