Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2004:
[Freeciv-Dev] Re: (PR#7405) list cleanup 		Home

[Freeciv-Dev] Re: (PR#7405) list cleanup

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#7405) list cleanup
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Fri, 13 Feb 2004 05:15:31 -0800
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=7405 >

On Wed, 11 Feb 2004, Raimar Falke wrote:
> > > Uhh. Bad idea. It changes the semantics of the function thus code like:
> > >
> > > unlink_all()
> > > insert()
> > >
> > > becomes broken.
> >
> > That is never used anywhere, AFAICT.
>
> Well you can prove this? Or catch it?

I can catch it when it happens, log it, and then gracefully recover by
inserting a new reference to the list into the list of lists - losing only
the debug info when that feature is turned on.

I can also separate unlink_all() and free(). This should make it clear
that calling free() then insert() is an error.

  - Per
[Prev in Thread] Current Thread [Next in Thread]