[Freeciv-Dev] Re: (PR#7405) list cleanup

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7405 >

On Tue, Feb 10, 2004 at 12:16:08AM -0800, Per I. Mathisen wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7405 >
> 
> On Mon, 9 Feb 2004, Raimar Falke wrote:
> > > +assert(conn_list_size(&pplayer->connections) == 0);
> > > +conn_list_unlink_all(&pplayer->connections);
> >
> > If the first doesn't kill the program isn't the second a nop?!
> 
> Not if #ifdef NDEBUG...

I see.

> Also, if an unlink_all() becomes necessary to actually remove all list
> data, as my genlist patch does, calling unlink_all() on an empty list is
> not superfluous but necessary.

Uhh. Bad idea. It changes the semantics of the function thus code like:

  unlink_all()
  insert()

becomes broken. Another point is that the function name is plain
misleading in such a case.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I heard if you play the NT-4.0-CD backwards, you get a satanic message."
 "That's nothing, if you play it forward, it installs NT-4.0"