[Freeciv-Dev] Re: (PR#7385) overview isn't updated

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7385 >

Raimar Falke wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7385 >
> 
> On Mon, Feb 09, 2004 at 02:08:27AM -0800, Raimar Falke wrote:
> 
>>Alternative suggestions:
>> - a flag which is set every time the overview (backing store) is
>> updated and cleared when the backing store is copied to the screen
> 
> 
> Untested patch for this attached.

A workable concept.  But it won't work for recentering the map (no 
dirtying), and possibly not for expose events either (although these do 
seem to work).

I'd do the interface a bit differently:

   dirty_overview() => sets dirty flag
     (or queue_overview_redraw())

   flush_dirty_overview() => checks dirty flag, calls redraw
     (or unqueue_overview_redraw())

   redraw_overview => doesn't check dirty flag

flush_dirty_overview() can be called from inside unqueue_mapview_updates().

In future the queue and dirty systems should be merged, though I'm not 
quite sure how to do this.

jason